Skip to content

Improved collapse_debuginfo attribute, added command-line flag#119828

Merged
bors merged 1 commit into
rust-lang:masterfrom
azhogin:azhogin/collapse_debuginfo_improved_attr
Jan 19, 2024
Merged

Improved collapse_debuginfo attribute, added command-line flag#119828
bors merged 1 commit into
rust-lang:masterfrom
azhogin:azhogin/collapse_debuginfo_improved_attr

Conversation

@azhogin

@azhogin azhogin commented Jan 10, 2024 •
edited by petrochenkov
Loading

Copy link
Copy Markdown
Contributor

Improved attribute collapse_debuginfo with variants: #[collapse_debuginfo=(no|external|yes)].
Added command-line flag for default behaviour.
Work-in-progress: will add more tests.

cc #100758

@rustbot

rustbot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2024
@WaffleLapkin

WaffleLapkin commented Jan 10, 2024

Copy link
Copy Markdown
Member

Marking as S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. , once this is ready for review, please use @rustbot review (learn more about rustbot commands). @rustbot author.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024
@azhogin

azhogin commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned WaffleLapkin Jan 10, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 0d05bf8 to f3adf78 Compare January 11, 2024 06:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from f3adf78 to 6e21180 Compare January 11, 2024 06:44
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 6e21180 to 80619bc Compare January 11, 2024 14:59
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch 3 times, most recently from 48a832c to 2065508 Compare January 14, 2024 18:55
@azhogin azhogin changed the title Improved collapse_debuginfo attribute, added command-line flag (WIP) Improved collapse_debuginfo attribute, added command-line flag Jan 14, 2024
@azhogin azhogin marked this pull request as ready for review January 14, 2024 19:52
@azhogin

azhogin commented Jan 14, 2024

Copy link
Copy Markdown
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2024
petrochenkov
petrochenkov reviewed Jan 15, 2024
View reviewed changes
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread compiler/rustc_span/src/hygiene.rs Outdated
Comment thread tests/debuginfo/collapse-debuginfo-external-flag-overriden-by-attr.rs Outdated
Comment thread compiler/rustc_session/src/options.rs Outdated
Comment thread compiler/rustc_session/src/options.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2024
@bors

This comment was marked as resolved.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 2065508 to 0743f9c Compare January 16, 2024 15:38
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 0743f9c to 150d59c Compare January 16, 2024 18:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 150d59c to 6dddef7 Compare January 16, 2024 19:27
petrochenkov
petrochenkov reviewed Jan 16, 2024
View reviewed changes
Comment thread compiler/rustc_session/src/config.rs Outdated
Comment thread compiler/rustc_expand/src/mbe/macro_rules.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
Comment thread compiler/rustc_expand/src/base.rs Outdated
@azhogin azhogin force-pushed the azhogin/collapse_debuginfo_improved_attr branch from 6dddef7 to 8507f51 Compare January 17, 2024 16:18
@petrochenkov

petrochenkov commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

Looks ready and CI is green.
@bors r+

@bors

bors commented Jan 17, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8507f51 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2024
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 18, 2024
Merged
@bors bors merged commit c0da80f into rust-lang:master Jan 19, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 19, 2024
@petrochenkov petrochenkov mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.77.0

Development

Successfully merging this pull request may close these issues.

6 participants

@azhogin @rustbot @WaffleLapkin @rust-log-analyzer @bors @petrochenkov